Skip to content

fix: force delete option fixed on resource browser and app details page #4646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 4, 2024
Merged

fix: force delete option fixed on resource browser and app details page #4646

merged 5 commits into from
Mar 4, 2024

Conversation

@ashishdevtron
Copy link
Contributor

@ashishdevtron ashishdevtron commented Feb 7, 2024 •
edited
Loading

Description

exposed forceDelete param in json

Fixes #4430

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@ashishdevtron ashishdevtron changed the title fix: force delete fix fix: force delete option fixed on resource browser and app details page Feb 7, 2024
@github-actions
Copy link

github-actions bot commented Feb 14, 2024

PR is not linked to any issue, please make the corresponding changes in the body.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ashishdevtron ashishdevtron merged commit 0fc75ed into main Mar 4, 2024
@ashishdevtron ashishdevtron deleted the force-delete branch March 4, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikramdevtron vikramdevtron vikramdevtron approved these changes

@kripanshdevtron kripanshdevtron Awaiting requested review from kripanshdevtron

@nishant-d nishant-d Awaiting requested review from nishant-d

Assignees

No one assigned

Labels

PR:Ready-to-Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: Force delete option on devtron dashboard doesn't work as expected

3 participants

@ashishdevtron @vikramdevtron